Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create abstract gallery display #20

Merged
merged 12 commits into from
Aug 27, 2024
Merged

Conversation

MaHaWo
Copy link
Collaborator

@MaHaWo MaHaWo commented Aug 23, 2024

  • add a general GalleryDisplay component:

    • have a gallery containing arbitrary components as its tiles
    • use this for frontpage and childrenoverview
    • searchable
  • add dummy childrenoverview page

  • make CardDisplay more flexible wrt styles

  • adjust bottom navbar to be able to switch next/previous buttons on and off

    • makes it usable if only a help or info button is needed
  • minor corrections of variable names and stylings.

  • not included:

    • paginated children overview
    • indicator functionality if survey for a child is incomplete (on account of lack of backend)

@MaHaWo MaHaWo linked an issue Aug 23, 2024 that may be closed by this pull request
@MaHaWo MaHaWo requested a review from lkeegan August 23, 2024 14:52
@MaHaWo
Copy link
Collaborator Author

MaHaWo commented Aug 27, 2024

@lkeegan I changed the style of the image and removed the background from the dummy images. Do you want to have another look?

Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@MaHaWo MaHaWo merged commit dce46f6 into main Aug 27, 2024
3 checks passed
@MaHaWo MaHaWo deleted the create-abstract-gallery-display branch August 27, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create abstract component for a gallery display
2 participants