Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create registration template component #21

Merged
merged 20 commits into from
Aug 27, 2024

Conversation

MaHaWo
Copy link
Collaborator

@MaHaWo MaHaWo commented Aug 26, 2024

  • make the AbstractDataInput component more abstract such that accepts different components for its items
  • add AbstractRegistrationForm for registering new users.
  • add a page for child registration using the same form as for user registration.
  • create new pages to have a user registration flow to click through

@MaHaWo
Copy link
Collaborator Author

MaHaWo commented Aug 27, 2024

@lkeegan do you want to have another look?

  • fixed labels
  • made pages into components
  • augmented login component with the usual bells and whistles (forgot password? not registered yet? remember me?)
  • removed nav buttons from forms
  • didn´t refator abstract components yet because that needs more insight from functionality, as discussed.

Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

src/lib/components/UserLogin.svelte Outdated Show resolved Hide resolved
@MaHaWo MaHaWo merged commit 58f1af7 into main Aug 27, 2024
3 checks passed
@MaHaWo MaHaWo deleted the create-registration-template-component branch August 27, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement login and registration page Add abstract frontend page for login and register forms
2 participants