Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor data input element (again) #73

Merged
merged 35 commits into from
Sep 26, 2024
Merged

Conversation

MaHaWo
Copy link
Collaborator

@MaHaWo MaHaWo commented Sep 20, 2024

  • add custom RadioList component with support for single or multiple value input
  • remove weird behavior when having additional values provided through a textbox. the additional stuff lives in a separate variable now.
  • integrate RadioList into ChildRegistration and UserRegistration pages. Make things with less than five elements RadioList, data input elements with more I left as dropdowns because I found it visually overwhelming.
  • make ChildrenRegistration and UserRegistration the same since they do the same thing
    Question: Should they be Modal perhaps?
  • move all the data definitions into the respective +page.svelte from the component svelte files.

@MaHaWo MaHaWo changed the title add initial skeleton for CheckboxList Refactor data input element (again) Sep 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 339 lines in your changes missing coverage. Please review.

Project coverage is 18.10%. Comparing base (c12c462) to head (908718a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...d/src/routes/childLand/childDataInput/+page.svelte 0.00% 114 Missing ⚠️
...end/src/routes/userLand/userDataInput/+page.svelte 0.00% 85 Missing and 1 partial ⚠️
.../src/routes/userLand/userRegistration/+page.svelte 0.00% 36 Missing and 1 partial ⚠️
...end/src/lib/components/ChildrenRegistration.svelte 0.00% 20 Missing ⚠️
frontend/src/lib/components/UserDataInput.svelte 0.00% 18 Missing ⚠️
...tend/src/lib/components/DataInput/DataInput.svelte 0.00% 16 Missing ⚠️
...end/src/lib/components/DataInput/Fileupload.svelte 0.00% 11 Missing and 1 partial ⚠️
...tend/src/lib/components/DataInput/RadioList.svelte 0.00% 11 Missing and 1 partial ⚠️
...rontend/src/routes/userLand/userLogin/+page.svelte 0.00% 11 Missing ⚠️
...rontend/src/lib/components/UserRegistration.svelte 0.00% 8 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   18.38%   18.10%   -0.29%     
==========================================
  Files          73       75       +2     
  Lines        3067     3116      +49     
  Branches      106      108       +2     
==========================================
  Hits          564      564              
- Misses       2450     2497      +47     
- Partials       53       55       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaHaWo MaHaWo linked an issue Sep 24, 2024 that may be closed by this pull request
@MaHaWo MaHaWo self-assigned this Sep 24, 2024
@MaHaWo MaHaWo requested a review from lkeegan September 24, 2024 08:50
@MaHaWo
Copy link
Collaborator Author

MaHaWo commented Sep 25, 2024

@lkeegan you want to have another look?

Copy link

sonarcloud bot commented Sep 25, 2024

Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - as discussed I'll try to construct the JSON that the backend will provide, then we can revisit this

@MaHaWo MaHaWo merged commit 9b050b7 into main Sep 26, 2024
7 checks passed
@MaHaWo MaHaWo deleted the add-checkboxes-to-data-input branch September 26, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[component architecture] Add ability to have checkboxes in DataInput
3 participants