Add search function for milestone components #87
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 19.49% 18.38% -1.11%
==========================================
Files 73 73
Lines 2904 3067 +163
Branches 106 106
==========================================
- Hits 566 564 -2
- Misses 2285 2450 +165
Partials 53 53 ☔ View full report in Codecov by Sentry. |
| // button label contains info about completion status => use for search | ||
| if (key === 'fertig') { | ||
| return item.progress === 1; | ||
| } else if (key === 'unfertig') { | ||
| return item.progress < 1; | ||
| } else { | ||
| return item.header.toLowerCase().includes(key.toLowerCase()); | ||
| } |
There was a problem hiding this comment.
If we want to filter for complete/incomplete it might be nicer to have a couple of checkboxes for this under the search box, versus having the user type fertig
There was a problem hiding this comment.
hm, yeah.... that would require an additional element in the UI however and it would add significant complexity to it. I'm not sure that's worth it.
….com:ssciwr/mondey-frontend-prototype into add-search-function-for-milestone-components
….com:ssciwr/mondey-frontend-prototype into add-search-function-for-milestone-components
….com:ssciwr/mondey-frontend-prototype into add-search-function-for-milestone-components
|
GalleryDisplayaccept an additional variablesearchData(an array of objects) that defines categories of data to be searched for.bind:this={thing}=>thing.focus()didn´t work. Left for another PR that fixes this kind of usability stuffmilestoneoverviewandmilestonegroup. Which ones we want actually can be decided quickly, since we just need to exchange an element in an array to add or remove them.