Add milestones to backend #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 18.41% 20.62% +2.21%
==========================================
Files 73 75 +2
Lines 3068 3088 +20
Branches 106 107 +1
==========================================
+ Hits 565 637 +72
+ Misses 2450 2397 -53
- Partials 53 54 +1 ☔ View full report in Codecov by Sentry. |
lkeegan
force-pushed
the
backend_milestone_endpoints
branch
5 times, most recently
from
9d2c090
to
b083883
Compare
- add/update Milestone, MilestoneText, MilestoneImage models - add admin endpoints to create / update / delete milestones Make endpoint naming more consistent - use plurals for all collections of entities - use PUT instead of PATCH since these endpoints take the entire entity, not just selected fields to update Refactor - use factory pattern for app and routers to make it easier to modify app settings in tests - extract common router code into utils - extend and refactor backend tests
lkeegan
force-pushed
the
backend_milestone_endpoints
branch
from
b083883
to
1744f2a
Compare
|
|
... started review, but need some more time ... |
MaHaWo
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make endpoint naming more consistent