Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rucio replica sorting service using geolocation #896

Merged
merged 21 commits into from
Nov 17, 2024

Conversation

ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Oct 22, 2024

This uses functionality added to the DID finder library (ssl-hep/ServiceX_DID_Finder_lib#34) to sort replicas for the Rucio DID finder. In principle a similar pattern can be implemented for other DID finders, though none of the others provide multiple replicas at the moment.

@ponyisi ponyisi changed the title Working service but no callbacks from DID finder yet Generic replica sorting service using geolocation Oct 22, 2024
@BenGalewsky
Copy link
Contributor

@ponyisi will you replace this PR with a simplified one that is just implemented in the Rucio DID finder?

@ponyisi ponyisi requested a review from BenGalewsky November 12, 2024 21:13
@ponyisi ponyisi changed the title Generic replica sorting service using geolocation Rucio replica sorting service using geolocation Nov 12, 2024
@ponyisi
Copy link
Collaborator Author

ponyisi commented Nov 12, 2024

I will "un-draft" this once the DID finder library is updated and I don't have to point at a git branch any more... but I've verified it works OK.

@ponyisi
Copy link
Collaborator Author

ponyisi commented Nov 13, 2024

Resolves #766

@BenGalewsky
Copy link
Contributor

@ponyisi -- looked at the code in the DID Finder Library - Given the YAGNI principle I would prefer that we implement this in the Rucio DID finder to start with. We are going to find problems and enhancements and fixing things in the library is a drag.

I would prefer to see this initial implementation entirely done in the Rucio DID Finder and then we can move it to the library once we find a use case for that.

@ponyisi ponyisi marked this pull request as ready for review November 14, 2024 17:25
@ponyisi
Copy link
Collaborator Author

ponyisi commented Nov 14, 2024

@BenGalewsky whatever's needed to get this in ... it's rather desperately needed....

Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I think we have different ideas about code clarity, but this should be ok to maintain

@ponyisi ponyisi merged commit deeae0d into develop Nov 17, 2024
75 checks passed
@ponyisi ponyisi deleted the replica_distance_service branch November 17, 2024 21:16
@ponyisi ponyisi added this to the 1.5.5 bug fixes milestone Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants