Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove encryption functionality and tests #348

Closed
wants to merge 2 commits into from
Closed

Remove encryption functionality and tests #348

wants to merge 2 commits into from

Conversation

MatheusFranco99
Copy link
Contributor

@MatheusFranco99 MatheusFranco99 commented Jan 16, 2024 •
edited
Loading

Encryption functions were not used anywhere except from their own tests. Thus, we deprecate this functionality and its respective tests.

@MatheusFranco99 MatheusFranco99 self-assigned this Jan 16, 2024
@GalRogozinski GalRogozinski self-requested a review February 4, 2024 12:07
@GalRogozinski
Copy link
Contributor

I am still thinking about this...
@moshe-blox confirmed the test wasn't used...
But there is a point of having such test in the spec, depending on how we define the scope

I'll talk to @lior-blox about this...

@GalRogozinski GalRogozinski mentioned this pull request Apr 3, 2024
Merged
5 tasks
@MatheusFranco99
Copy link
Contributor Author

@GalRogozinski
It seems that this should be closed, right? As it's part of the protocol being used somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GalRogozinski GalRogozinski Awaiting requested review from GalRogozinski

@liorrutenberg liorrutenberg Awaiting requested review from liorrutenberg

Assignees

@MatheusFranco99 MatheusFranco99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatheusFranco99 @GalRogozinski