committee consensus #379
Merged
committee consensus #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkryuchkov
reviewed
May 3, 2024
ssv/committee_runner.go
Outdated
| // This function signature returns only one domain type | ||
| // instead we rely on expectedPostConsensusRootsAndBeaconObjects that is called later | ||
| func (cr CommitteeRunner) expectedPostConsensusRootsAndDomain() ([]ssz.HashRoot, phase0.DomainType, error) { | ||
| return []ssz.HashRoot{}, types.DomainAttester, nil |
There was a problem hiding this comment.
Why does it always return DomainAttester? What about DomainSyncCommittee?
There was a problem hiding this comment.
This function should be deleted imo because it isn't used..
or code should be refactored to somehow use it
|
@GalRogozinski ClusterID should be renamed to CommitteeID |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.