Remove entropy in tests #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalRogozinski
approved these changes
Nov 12, 2024
Comment on lines
-42
to
-46
|
|
||
| // decrypt test's cipher and compare to plain text | ||
| plain2, err := types.Decrypt(sk, test.CipherText) | ||
| require.NoError(t, err) | ||
| require.EqualValues(t, test.PlainText, plain2) |
GalRogozinski
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Solve entropy in simple case in which a fixed key can be used * Solve entropy in test type by changing the test spec: removing CypherText and using fixed keys
GalRogozinski
pushed a commit
that referenced
this pull request
Dec 19, 2024
* reset on dev * Tests - Remove entropy in tests (#507) * Solve entropy in simple case in which a fixed key can be used * Solve entropy in test type by changing the test spec: removing CypherText and using fixed keys * udpate max signatures in PartialSignatureMessages * update max signatures in maxmsgsize tests * generate JSON tests
GalRogozinski
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Solve entropy in simple case in which a fixed key can be used * Solve entropy in test type by changing the test spec: removing CypherText and using fixed keys
GalRogozinski
pushed a commit
that referenced
this pull request
Dec 19, 2024
* reset on dev * Tests - Remove entropy in tests (#507) * Solve entropy in simple case in which a fixed key can be used * Solve entropy in test type by changing the test spec: removing CypherText and using fixed keys * udpate max signatures in PartialSignatureMessages * update max signatures in maxmsgsize tests * generate JSON tests
GalRogozinski
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Solve entropy in simple case in which a fixed key can be used * Solve entropy in test type by changing the test spec: removing CypherText and using fixed keys
GalRogozinski
pushed a commit
that referenced
this pull request
Dec 19, 2024
* reset on dev * Tests - Remove entropy in tests (#507) * Solve entropy in simple case in which a fixed key can be used * Solve entropy in test type by changing the test spec: removing CypherText and using fixed keys * udpate max signatures in PartialSignatureMessages * update max signatures in maxmsgsize tests * generate JSON tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes the entropy that exists in
typestests. The two changes were:SignedSSVMessageTesttest, we simply started using a constant key.EncryptionSpecTesttest, we had to change the test structure. We removed theCypherTextfield, which inevitably has entropy, and used constant keys, instead of generating new ones.Closes #308