fail on unexpected err

ssvlabs · Oct 28, 2024 · d5c4d31 · d5c4d31
1 parent 67138b1
commit d5c4d31
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/ekm/signer_key_manager_test.go b/ekm/signer_key_manager_test.go
@@ -849,9 +849,12 @@ func TestConcurrentSlashingProtectionAttData(t *testing.T) {
 	// Count errors and successes.
 	var slashableErrors, successCount int
 	for err := range errChan {
-		if err != nil && err.Error() == "slashable attestation (HighestAttestationVote), not signing" {
+		if err != nil {
+			if err.Error() != "slashable attestation (HighestAttestationVote), not signing" {
+				require.Fail(t, "unexpected error: %v", err)
+			}
 			slashableErrors++
-		} else if err == nil {
+		} else {
 			successCount++
 		}
 	}
@@ -904,9 +907,12 @@ func TestConcurrentSlashingProtectionBeaconBlock(t *testing.T) {
 	// Count errors and successes.
 	var slashableErrors, successCount int
 	for err := range errChan {
-		if err != nil && err.Error() == "slashable proposal (HighestProposalVote), not signing" {
+		if err != nil {
+			if err.Error() != "slashable proposal (HighestProposalVote), not signing" {
+				require.Fail(t, "unexpected error: %v", err)
+			}
 			slashableErrors++
-		} else if err == nil {
+		} else {
 			successCount++
 		}
 	}