optimization: (eventsyncer) don't remove QBFT instances to speed up historical syncing #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AKorpusenko
requested review from
y0sher,
MatusKysel,
guym-blox and
moshe-blox
y0sher
approved these changes
Aug 12, 2024
MatusKysel
reviewed
Aug 13, 2024
moshe-blox
reviewed
Aug 13, 2024
| messageID := convert.NewMsgID(eh.networkConfig.DomainType(), share.ValidatorPubKey[:], role) | ||
| return store.CleanAllInstances(logger, messageID[:]) | ||
| } | ||
| err := eh.storageMap.Each(removeDecidedMessages) |
There was a problem hiding this comment.
is storageMap still used elsewhere? if not we should remove it
There was a problem hiding this comment.
it's not used, I will remove it (as @AKorpusenko is sick today)
moshe-blox
approved these changes
Aug 13, 2024
moshe-blox
changed the title
|
well done! @y0sher @AKorpusenko |
y0sher
added a commit
that referenced
this pull request
Oct 28, 2024
…istorical syncing (#1615) * optimize badger delete action * try another optimization * use dropprefix instead of delete all keys * drop messages only when own share or fullnode * removed usage of store.CleanAllInstances * remove storageMap from eventhandler --------- Co-authored-by: y0sher <lyosher@gmail.com> Co-authored-by: Matus Kysel <matus@ssvlabs.io>
y0sher
added a commit
that referenced
this pull request
Oct 28, 2024
…ync [main] (#1824) * optimization: (eventsyncer) don't remove QBFT instances to speed up historical syncing (#1615) * optimize badger delete action * try another optimization * use dropprefix instead of delete all keys * drop messages only when own share or fullnode * removed usage of store.CleanAllInstances * remove storageMap from eventhandler --------- Co-authored-by: y0sher <lyosher@gmail.com> Co-authored-by: Matus Kysel <matus@ssvlabs.io> * fix build and lint --------- Co-authored-by: Anton Korpusenko <antokorp@gmail.com> Co-authored-by: Matus Kysel <matus@ssvlabs.io> Co-authored-by: Nikita Kryuchkov <nkryuchkov10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1593