exporter: decideds endpoint; fix signers; fix resolving role; cache domain; fix convert #1766

olegshmuelov · 2024-09-30T13:30:39Z

Changes to Exporter:

port feat: (API) decided instances endpoint #1632
- add decided instances endpoint (GET /v1/exporter/decideds)
- add X-SSV-Node-Version header
fix role type casting when using the convert package
allow saving partial signatures of length not equal to 3f+1
cache domain requests to beacon node within one epoch
make resolving beacon role type by roots work
fix wrong participants rendering by merging committees on new quorum instead of overwriting

y0sher · 2024-10-01T06:31:11Z

networkconfig/holesky-stage.go

@@ -16,7 +16,7 @@ var HoleskyStage = NetworkConfig{
 	GenesisEpoch:         1,
 	RegistrySyncOffset:   new(big.Int).SetInt64(84599),
 	RegistryContractAddr: "0x0d33801785340072C452b994496B19f196b7eE15",
-	AlanForkEpoch:        99999999,
+	//AlanForkEpoch:        99999999,


lets not merge this

api/handlers/exporter.go

api/server/server.go

This reverts commit 50c86a5.

This reverts commit e091617.

y0sher · 2024-10-16T07:28:18Z

networkconfig/holesky-stage.go

@@ -16,8 +16,8 @@ var HoleskyStage = NetworkConfig{
 	GenesisEpoch:         1,
 	RegistrySyncOffset:   new(big.Int).SetInt64(84599),
 	RegistryContractAddr: "0x0d33801785340072C452b994496B19f196b7eE15",
-	AlanForkEpoch:        999999999,
-	DiscoveryProtocolID:  [6]byte{'s', 's', 'v', 'd', 'v', '5'},
+	//AlanForkEpoch:        999999999,


should not be in this PR even though stage is going to be post-fork from now..

should not be in this PR even though stage is going to be post-fork from now..

yes, should be reverted once argo sensor is deleted

next time just please create a separate deploy branch to keep the main PR clean.

api/handlers/exporter.go

protocol/v2/ssv/validator/non_committee_validator.go

nkryuchkov

Requesting changes not to forget to revert AlanForkEpoch once it's tested

y0sher · 2024-10-30T13:30:20Z

protocol/v2/ssv/validator/domain_cache.go

+
+type DomainCache struct {
+	beaconNode beacon.BeaconNode
+	cache      *ttlcache.Cache[domainCacheKey, phase0.Domain]


seems to be threadsafe from looking at the code

y0sher · 2024-10-30T14:18:32Z

protocol/v2/ssv/validator/domain_cache.go

+	"github.com/ssvlabs/ssv/protocol/v2/blockchain/beacon"
+)
+
+type DomainCache struct {


nice addition, we should probably use this in the actual runners and not just exporter! of course in a different PR.

y0sher

@olegshmuelov @nkryuchkov
Good job on figuring out all the quirks here! this is a big transition in exporter.

moshe-blox

LGTM

well done @olegshmuelov @nkryuchkov @y0sher 💪

let's not forget to let @andrew-blox know that this should be QA'd before release (this will probably go in v2.0.2 after the fork, except for private early release to exporter operators)

olegshmuelov added 7 commits September 30, 2024 14:37

draft

408206e

add comment

4868b2b

use runner role instead beacon role

7861868

lint fix

2e6cf5d

add log

47664a2

run exporter post-fork

41ccc36

support hex strings with '0x' prefix for public keys in exporter API

fdd5d20

olegshmuelov self-assigned this Sep 30, 2024

olegshmuelov added 4 commits September 30, 2024 16:33

cleanups

a2990fe

revert to beacon role

1465916

use trim

0bd283a

adapt to older response format

f482cec

olegshmuelov marked this pull request as ready for review September 30, 2024 15:20

olegshmuelov requested review from moshe-blox, y0sher and nkryuchkov September 30, 2024 15:27

y0sher reviewed Oct 1, 2024

View reviewed changes

nkryuchkov requested changes Oct 2, 2024

View reviewed changes

nkryuchkov added 7 commits October 1, 2024 22:48

fix JSON capital case

d8da4a7

change type of From and To

924528c

fix error text if values are equal

d0491f8

continue if one of pubkeys/duties has no participants

90906c2

allow saving participants not equal to 3f+1

1a53ee6

save participants if quorum is longer than existing one

bd94915

remove redundant check

ab17ced

nkryuchkov reviewed Oct 2, 2024

View reviewed changes

api/server/server.go Show resolved Hide resolved

nkryuchkov added 4 commits October 2, 2024 09:55

add uint in Bind

1d2aa88

consider failure to bind params as a bad request

e74ac7b

fix role order in convert package

50c86a5

Revert "fix role order in convert package"

4189281

This reverts commit 50c86a5.

olegshmuelov and others added 4 commits October 15, 2024 18:58

Merge branch 'stage' into exporter-api-alan-post-fork

4ad943d

Revert "add logs when saving roots"

3c5914d

This reverts commit e091617.

fix event syncer tests

64e00f6

fix TestHandleBlockEventsStream

1fa0efe

y0sher reviewed Oct 16, 2024

View reviewed changes

olegshmuelov added 2 commits October 16, 2024 12:14

avoid redundant root computations

f11692e

Delete root_cache.go

1b2846c

olegshmuelov requested review from y0sher and nkryuchkov October 16, 2024 10:24

nkryuchkov approved these changes Oct 16, 2024

View reviewed changes

y0sher reviewed Oct 21, 2024

View reviewed changes

api/handlers/exporter.go Outdated Show resolved Hide resolved

y0sher reviewed Oct 21, 2024

View reviewed changes

protocol/v2/ssv/validator/non_committee_validator.go Outdated Show resolved Hide resolved

nkryuchkov added 3 commits October 29, 2024 20:03

improve handling non-existing roles

8e52867

wrap errors into api.Error

1249010

merge quorums

c405abd

nkryuchkov requested changes Oct 29, 2024

View reviewed changes

y0sher reviewed Oct 30, 2024

View reviewed changes

y0sher approved these changes Oct 30, 2024

View reviewed changes

moshe-blox mentioned this pull request Oct 30, 2024

feat: (API) decided instances endpoint #1632

Closed

revert config change

44e1729

nkryuchkov approved these changes Oct 30, 2024

View reviewed changes

y0sher changed the title ~~Exporter Api (Alan post-fork)~~ feat: exporter http api and bug fixes Oct 30, 2024

nkryuchkov changed the title ~~feat: exporter http api and bug fixes~~ exporter: add decideds endpoint; fix signers; fix resolving role; cache domain; fix convert Oct 30, 2024

nkryuchkov changed the title ~~exporter: add decideds endpoint; fix signers; fix resolving role; cache domain; fix convert~~ exporter: decideds endpoint; fix signers; fix resolving role; cache domain; fix convert Oct 30, 2024

approve spec diff

5fa1a06

moshe-blox approved these changes Oct 30, 2024

View reviewed changes

nkryuchkov merged commit a020f5a into stage Oct 30, 2024
6 checks passed

nkryuchkov deleted the exporter-api-alan-post-fork branch October 30, 2024 15:38

olegshmuelov restored the exporter-api-alan-post-fork branch October 30, 2024 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

exporter: decideds endpoint; fix signers; fix resolving role; cache domain; fix convert #1766

exporter: decideds endpoint; fix signers; fix resolving role; cache domain; fix convert #1766

olegshmuelov commented Sep 30, 2024 •

edited by nkryuchkov

Loading

y0sher Oct 1, 2024

nkryuchkov Oct 30, 2024

y0sher Oct 16, 2024

olegshmuelov Oct 16, 2024

y0sher Oct 30, 2024

nkryuchkov Oct 30, 2024

nkryuchkov left a comment

y0sher Oct 30, 2024

y0sher Oct 30, 2024

y0sher left a comment

moshe-blox left a comment •

edited

Loading

exporter: decideds endpoint; fix signers; fix resolving role; cache domain; fix convert #1766

exporter: decideds endpoint; fix signers; fix resolving role; cache domain; fix convert #1766

Conversation

olegshmuelov commented Sep 30, 2024 • edited by nkryuchkov Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nkryuchkov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

y0sher left a comment

Choose a reason for hiding this comment

moshe-blox left a comment • edited Loading

Choose a reason for hiding this comment

olegshmuelov commented Sep 30, 2024 •

edited by nkryuchkov

Loading

moshe-blox left a comment •

edited

Loading