Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (exporter) revert adding beacon vote cache #1832

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: (exporter) revert adding beacon vote cache #1832

merged 1 commit into from
Oct 31, 2024

Conversation

nkryuchkov
Copy link
Contributor

Adding a beacon vote cache seems to have broken saving roots in some way and caused a lot of "no roles found for quorum root" logs

This PR is a hotfix that just reverts adding the cache and fixes those errors

If we decide to add the cache, we'll do it in another PR

@nkryuchkov nkryuchkov added bug Something isn't working critical Needs immediate attention exporter Related to exporter labels Oct 30, 2024
iurii-ssv
iurii-ssv approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@iurii-ssv iurii-ssv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

olegshmuelov
olegshmuelov approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@olegshmuelov olegshmuelov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open a new issue to bring back the root calculation optimization

@olegshmuelov olegshmuelov mentioned this pull request Oct 31, 2024
Open
@moshe-blox moshe-blox changed the title [hotfix] exporter: revert adding beacon vote cache fix: (exporter) revert adding beacon vote cache Oct 31, 2024
@moshe-blox moshe-blox merged commit 8a5bcfc into stage Oct 31, 2024
6 checks passed
@moshe-blox moshe-blox deleted the exporter-revert-beacon-vote-cache branch October 31, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0sher y0sher y0sher approved these changes

@olegshmuelov olegshmuelov olegshmuelov approved these changes

@moshe-blox moshe-blox moshe-blox approved these changes

@iurii-ssv iurii-ssv iurii-ssv approved these changes

Assignees
No one assigned
Labels
bug Something isn't working critical Needs immediate attention exporter Related to exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nkryuchkov @y0sher @olegshmuelov @moshe-blox @iurii-ssv