-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding route dependencies module. #251
Conversation
@jonhealy1 sorry I've been at a conference so have only just caught up on the authentication work. The basic auth looks great. Am I right in saying that all endpoints are now closed unless they're included in the public_endpoints list in the |
@pedro-cf Hi Pedro. Are you able to look at this pr and respond to @rhysrevans3? I think you would do a better job with this. Thanks! |
Greetings, if |
@jonhealy1 @pedro-cf thanks both I think I understand now. Could I get your opinion on this pull request as it also deals with auth. Are you happy that this and basic auth can co-exist? Or would you like me to try and merge the two? I currently don't have a way to protect all endpoints without explicitly writing them all out. You could add wildcards but this would probably need changes to https://github.com/stac-utils/stac-fastapi |
I definitely like the idea of supporting OAuth2. |
…api-elasticsearch into route_dependencies
Wondering about the best way to integrate this with basic auth? This will need instructions added to the readme as well and a docker-compose demo file I think. |
I've been thinking the same thing I will add instructions to the readme and a docker-compose demo file. They do currently work together but it might be confusing to have both in their current implementation. I could update basic auth to use this pull requests methods but it would change the config and would remove the another thought I had was this would fit better in the stac-fastapi so it can be used in all of the backends? |
I've made a pull request in stac-fastapi that would allow for default route dependencies to be added. This would make the merging of basic auth and this pull request much simpler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, I would suggest:
- add jsonschema validation for the
route_dependencies.json
- add real complete working examples
route_dependencies.json
…ch into route_dependencies
…ch into route_dependencies
I've add some jsonschema validation for route_dependencies. And added a second docker compose file that use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible work here
Nice changelog updates thanks! |
Moved changelog entries to Unreleased section.
@rhysrevans3 I moved the changelog entries to the Unreleased section in the changelog. |
Once we release a new version here and on PyPI then we move the changelog entries to the appropriate section which will hopefully be v3.0.0. Waiting for stac-fastapi v3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
@rhysrevans3 didn't notice but the README needs some correcting:
|
@pedro-cf Can you open up a new pr to fix this? Good catch. |
|
It does make some sense to move them to the examples folder I think. |
Description:
Generate a list of route dependencies from the environment variable
STAC_FASTAPI_ROUTE_DEPENDENCIES
or the file that this environment variable points to. Feed these route dependencies into theSTACApi
on initialisation.PR Checklist:
pre-commit run --all-files
)make test
)