Skip to content

Commit

Permalink
fix(webserver): raise liveness probe timeouts (#402)
Browse files Browse the repository at this point in the history
* fix(webserver): raise liveness probe timeouts

* fix ldap test on openshift 4.15

* comment on security context

* Raise webserver memory resource requests

* update changelog
  • Loading branch information
razvan authored Mar 8, 2024
1 parent d55a6c0 commit f9da16a
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 3 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
- Use new ldap::AuthenticationClassProvider `endpoint_url()` method ([#366]).
- Support git-sync `4.2.1` ([#387]).
- Use a lightweight DAG for the getting started guide to avoid OOM issues ([#401])
- Raise the default readiness and liveness probe timeouts of the webserver to 120s ([#402])
Also raise the memory request of the webserver from 2Gi to 3Gi.

### Fixed

Expand All @@ -37,6 +39,7 @@
[#381]: https://github.com/stackabletech/airflow-operator/pull/381
[#387]: https://github.com/stackabletech/airflow-operator/pull/387
[#401]: https://github.com/stackabletech/airflow-operator/pull/401
[#402]: https://github.com/stackabletech/airflow-operator/pull/402

## [23.11.0] - 2023-11-24

Expand Down
2 changes: 1 addition & 1 deletion rust/crd/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ fn default_resources(role: &AirflowRole) -> ResourcesFragment<AirflowStorageConf
max: Some(Quantity("2".into())),
},
MemoryLimitsFragment {
limit: Some(Quantity("2Gi".into())),
limit: Some(Quantity("3Gi".into())),
runtime_limits: NoRuntimeLimitsFragment {},
},
),
Expand Down
5 changes: 3 additions & 2 deletions rust/operator-binary/src/airflow_controller.rs
Original file line number Diff line number Diff line change
Expand Up @@ -871,8 +871,9 @@ fn build_server_rolegroup_statefulset(
port: IntOrString::Int(resolved_port.into()),
..TCPSocketAction::default()
}),
initial_delay_seconds: Some(20),
period_seconds: Some(5),
initial_delay_seconds: Some(60),
period_seconds: Some(10),
failure_threshold: Some(6),
..Probe::default()
};
airflow_container.readiness_probe(probe.clone());
Expand Down
6 changes: 6 additions & 0 deletions tests/templates/kuttl/ldap/03-install-openldap.yaml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ commands:
app.kubernetes.io/name: openldap
spec:
serviceAccountName: "ldap-sa"
#
# The security context below is necessary to avoid the following error on OpenShift:
# /opt/bitnami/scripts/openldap/setup.sh: line 102: /opt/bitnami/openldap/sbin/slappasswd: Operation not permitted
#
securityContext:
fsGroup: 1000
containers:
- name: openldap
image: docker.io/bitnami/openldap:2.5
Expand Down

0 comments on commit f9da16a

Please sign in to comment.