-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement KubernetesExecutor #311
Conversation
Jenkins after refactoring CRD structure: 🟢 https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/100/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works and it's ok but IMO:
ExecutorConfig
vsAirflowConfig
- the names are confusing don't reflect the intent.- Not sure if it's wise to introduce so much complication just because of the affinity issue of executors. But fortunately it's an implementation detail that we can hopefully change later without breaking the CRD.
This is almost adding support for complete new product. |
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
Description
Implements KubernetesExecutor.
Fixes #2.
Jenkins: 🟢 https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/99/
Implementation summary:
executor
field has been removed from the top-level cluster configworkers
role has been replaced with a complex enum specifying one of:celery
: this contains the worker config/roles etc.kubernetes
: this contains just the logging/resources of the config, plus env-overrides (has to be included as we don't have a role object)executor = kubernetes
, a pod template is deployed as config map that airflow will use to spawn pods for the DAG tasksTests on Openshift:
Definition of Done Checklist
Author
Reviewer
Acceptance