Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow user-specified git-sync config settings #335

Merged
merged 9 commits into from
Oct 13, 2023
Merged

allow user-specified git-sync config settings #335

merged 9 commits into from
Oct 13, 2023
+241 −141

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Oct 11, 2023 •
edited
Loading

Description

Fixes #332.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

sbernauer
sbernauer requested changes Oct 12, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!
Only some Nits

CHANGELOG.md Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
@adwk67
Copy link
Member Author

adwk67 commented Oct 13, 2023

Tests pass locally.

@adwk67 adwk67 requested a review from sbernauer October 13, 2023 08:20
@adwk67
Copy link
Member Author

adwk67 commented Oct 13, 2023

CI: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/103/

sbernauer
sbernauer approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adwk67 adwk67 added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit 3f55278 Oct 13, 2023
29 checks passed
@adwk67 adwk67 deleted the fix/gitsync-config branch October 13, 2023 10:36
@adwk67 adwk67 mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bugfix: allow --git-config entries in gitSync
2 participants
@adwk67 @sbernauer