Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Vector to version 0.33.0 in the tests #339

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Oct 31, 2023

Description

  • Upgrade Vector to version 0.33.0 in the tests, which is provided by the Vector Helm chart version 0.26.0.
  • Fix Clippy warnings

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, must have slipped :)
Can you replace this PR number with (334 i think) the vector update in the changelog?

@lfrancke
Copy link
Member

Just FYI that 0.33.1 has been released but not saying that we need to upgrade again

@siegfriedweber
Copy link
Member Author

Just FYI that 0.33.1 has been released but not saying that we need to upgrade again

I saw that the new Vector version and the corresponding Helm Chart are available on GitHub but it is not announced yet. However, the actual upgrade has to be done in the Docker image and operator-rs. This PR just fixes the integration tests to be in sync with the version used in the Docker image.

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for consistency since i forgot to bump it here. Bumping vector to 0.33.1 is another discussion and should be done in the release issue or in the docker images.

@siegfriedweber siegfriedweber added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit d6c2b6d Oct 31, 2023
29 checks passed
@siegfriedweber siegfriedweber deleted the feat/upgrade-vector branch October 31, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants