Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass gitsync credentials through properly #489

Merged
merged 8 commits into from
Aug 13, 2024
Merged

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Aug 12, 2024

Description

fix/pass gitsync credentials through properly

Jenkins: 🟢 https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/8/
OKD on replicated: 🟢

--- PASS: kuttl (972.27s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/ldap_airflow-latest-2.8.1_ldap-authentication-server-verification-tls_openshift-true_executor-kubernetes (206.21s)
        --- PASS: kuttl/harness/smoke_airflow-2.9.2_openshift-true_executor-kubernetes (270.44s)
        --- PASS: kuttl/harness/resources_airflow-latest-2.8.1_openshift-true (145.02s)
        --- PASS: kuttl/harness/orphaned-resources_airflow-latest-2.8.1_openshift-true (162.93s)
        --- PASS: kuttl/harness/mount-dags-configmap_airflow-latest-2.8.1_openshift-true_executor-kubernetes (145.00s)
        --- PASS: kuttl/harness/cluster-operation_airflow-latest-2.8.1_openshift-true (262.22s)
        --- PASS: kuttl/harness/logging_airflow-2.9.2_openshift-true_executor-kubernetes (479.25s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-2.8.1_openshift-true_executor-kubernetes (205.10s)

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@adwk67 adwk67 linked an issue Aug 12, 2024 that may be closed by this pull request
@adwk67 adwk67 requested a review from razvan August 13, 2024 12:25
@adwk67 adwk67 marked this pull request as ready for review August 13, 2024 12:25
@adwk67 adwk67 self-assigned this Aug 13, 2024
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@adwk67 adwk67 added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit 857d526 Aug 13, 2024
31 checks passed
@adwk67 adwk67 deleted the fix/git-sync-credentials branch August 13, 2024 15:11
@sbernauer sbernauer changed the title fix/pass gitsync credentials through properly fix: Pass gitsync credentials through properly Aug 14, 2024
@PaulienVa
Copy link
Contributor

Is this fix available in the nightly build? We are testing it atm and still see the error preventing our statefulsets to start up

@adwk67
Copy link
Member Author

adwk67 commented Aug 28, 2024

Yes, this is in the nightly build which we use for our integration-testing. Please open an issue if something is not working as expected.

@lfrancke
Copy link
Member

lfrancke commented Sep 4, 2024

Should this be mentioned in the release notes for 24.11? If so, could you please add a snippet?

@adwk67
Copy link
Member Author

adwk67 commented Sep 9, 2024

@lfrancke sorry for the delay on this. Here, as a comment, or in the changelog?

@adwk67
Copy link
Member Author

adwk67 commented Sep 10, 2024

Here's a snippet for the release notes:

Fixed in 24.11: in release 24.7 Airflow did not propagate git credentials correctly to the gitsync containers. This has now been corrected and works for both celery- and kubernetes workers.

@lfrancke
Copy link
Member

Sorry. Here is fine, thank you!

@lfrancke lfrancke added release-note Denotes a PR that will be considered when it comes time to generate release notes. type/bug labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/2024-11 release-note Denotes a PR that will be considered when it comes time to generate release notes. type/bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gitCredentialsSecret doesn't follow RFC 1123 specification
4 participants