Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add overrides integrationtests #490

Merged
merged 13 commits into from
Aug 26, 2024
Merged

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Aug 12, 2024

Description

Adding a caution hint for changing the pod template variable after pod overrides are already applied.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@xeniape xeniape changed the title chore: add hint for pod template chore: recapture pod_template to immutable after applying overrides Aug 13, 2024
@xeniape xeniape changed the title chore: recapture pod_template to immutable after applying overrides chore: add overrides integrationtests Aug 20, 2024
@xeniape xeniape self-assigned this Aug 22, 2024
@razvan razvan enabled auto-merge August 26, 2024 16:36
@razvan razvan added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 5cb377b Aug 26, 2024
31 checks passed
@razvan razvan deleted the chore/add-hint-for-pod-template branch August 26, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants