Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/more readable smoke test assert #496

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

Maleware
Copy link
Contributor

Description

As @NickLarsenNZ pointed out we could get better in code style and readability. This are suggested changes of him first used in stackabletech/superset-operator#533 and now being propagated through operators.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@Maleware Maleware self-assigned this Aug 29, 2024
@sbernauer sbernauer requested a review from NickLarsenNZ August 29, 2024 07:03
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Maleware Maleware added this pull request to the merge queue Sep 2, 2024
Merged via the queue into main with commit f213473 Sep 2, 2024
31 checks passed
@Maleware Maleware deleted the fix/more-readable-smoke-test-assert branch September 2, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants