-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenID Connect Support #524
Conversation
…irflow-operator into feature/tls-oidc
…irflow-operator into feature/tls-oidc
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick glance, will leave the rest for andrew :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good - I think some screenshots would help to explain how to use this feature from the UI-perspective.
Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com>
…irflow-operator into feature/tls-oidc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - nightly tests all ran successfully locally.
Suggested comment for the release notes:
|
We will need a fix #530 this will complete the Ticket. I forgot to add certificates to airflow via python certify. |
Description
closes #337
Definition of Done Checklist
Author
Reviewer
Acceptance