Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenID Connect Support #524

Merged
merged 31 commits into from
Oct 31, 2024
Merged

OpenID Connect Support #524

merged 31 commits into from
Oct 31, 2024

Conversation

Maleware
Copy link
Contributor

@Maleware Maleware commented Oct 29, 2024

Description

closes #337

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@Maleware
Copy link
Contributor Author

=== NAME  kuttl
    harness.go:407: run tests finished
    harness.go:515: cleaning up
    harness.go:572: removing temp folder: ""
--- PASS: kuttl (169.74s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/oidc_airflow-2.9.3_openshift-false (169.70s)
PASS

@Maleware
Copy link
Contributor Author

=== NAME  kuttl
    harness.go:407: run tests finished
    harness.go:515: cleaning up
    harness.go:572: removing temp folder: ""
--- PASS: kuttl (184.54s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/oidc_airflow-2.9.3_openshift-false (184.50s)
PASS

@adwk67 adwk67 self-requested a review October 30, 2024 08:27
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick glance, will leave the rest for andrew :)

Cargo.toml Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Show resolved Hide resolved
rust/crd/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - I think some screenshots would help to explain how to use this feature from the UI-perspective.

rust/crd/src/authentication.rs Outdated Show resolved Hide resolved
Maleware and others added 3 commits October 31, 2024 14:10
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nightly tests all ran successfully locally.

@adwk67
Copy link
Member

adwk67 commented Oct 31, 2024

Suggested comment for the release notes:

OpenID Connect is now supported by the airflow operator: this means that the necessary Flask dependencies have been added to the product image and that the operator can process OIDC authentication classes. It will still be necessary, however, for users to configure their own webserver configuration themselves, if they want to be directly redirected to the authentication authority.

@Maleware Maleware added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 6529f52 Oct 31, 2024
17 checks passed
@Maleware Maleware deleted the feature/tls-oidc branch October 31, 2024 15:10
@adwk67 adwk67 mentioned this pull request Nov 5, 2024
3 tasks
@Maleware
Copy link
Contributor Author

Maleware commented Nov 6, 2024

We will need a fix #530 this will complete the Ticket.

I forgot to add certificates to airflow via python certify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

OpenID Connect support
5 participants