fix: Update demos and documentation #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeniape
changed the title
sbernauer
reviewed
Jun 26, 2024
…d-cycling-data demos
xeniape
changed the title
sbernauer
changed the title
sbernauer
previously approved these changes
Jun 27, 2024
sbernauer
changed the title
fhennig
suggested changes
Jul 1, 2024
docs/modules/demos/pages/jupyterhub-pyspark-hdfs-anomaly-detection-taxi-data.adoc
Outdated
Show resolved
Hide resolved
docs/modules/demos/pages/jupyterhub-pyspark-hdfs-anomaly-detection-taxi-data.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
…tion-taxi-data.adoc Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
…tion-taxi-data.adoc Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
NickLarsenNZ
requested changes
Jul 12, 2024
Thanks for the idea! Tried it with local rendering and it looked fine to me. If someone else wants to try it and has some feedback though, I can update the screenshots as well. |
maltesander
reviewed
Jul 15, 2024
|
I'm ok with the images sizes, though some of the text is on the smaller side. We will add some tips for doing this in the new issue templates for the release process: stackabletech/issues#602 |
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some demo configurations (MinIO service name and Druid Middlemanager resources), commands (Kafka probing and SQL queries) and product UIs were outdated / defective. This PR fixes them. Also fixes minor typos and adds consistency between the two nifi-kafka-druid demos.
Extending this PR to other demos and their documentation as well. Similar tasks of updating screenshots, typos etc.