Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Build Druid from source #684

Merged
merged 17 commits into from
May 23, 2024
Merged

feat: Build Druid from source #684

merged 17 commits into from
May 23, 2024

Conversation

labrenbe
Copy link
Member

Description

Successfully ran smoke test with some flakiness that seems to be uncorrelated to this PR.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks

Preview Give feedback
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@labrenbe labrenbe requested a review from a team May 17, 2024 09:29
Copy link
Contributor

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a entry to the Changelog.md. Other than that, great work :)

druid/Dockerfile Outdated Show resolved Hide resolved
druid/Dockerfile Outdated Show resolved Hide resolved
@Maleware
Copy link
Contributor

Builds succeeded on arm64

labrenbe and others added 3 commits May 17, 2024 11:36
Co-authored-by: Maximilian Wittich <56642549+Maleware@users.noreply.github.com>
druid/Dockerfile Outdated Show resolved Hide resolved
conf.py Outdated Show resolved Hide resolved
@lfrancke
Copy link
Member

Thanks for this! I looked at it and have nothing to add that hasn't already been said.

sbernauer
sbernauer previously approved these changes May 23, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

druid/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Maleware Maleware enabled auto-merge May 23, 2024 08:39
@Maleware Maleware added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit ee26401 May 23, 2024
12 of 13 checks passed
@Maleware Maleware deleted the feat/build-druid-from-source branch May 23, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants