Skip to content

Commit

Permalink
fix(stackable-versioned): Remove type comparison and use into() on al…
Browse files Browse the repository at this point in the history
…l field conversions (#925)

* fix(stackable-versioned): Remove type comparison and use into() on all field conversions

Note: the from/to type comparison was semantically invalid as we have no information of the actual type which might still be an equivalent string (eg: foo::TypeA could be defined in two versions of a crate).

* chore(stackable-versioned): Update changelog

* test(stackable-versioned): Update test snapshots

* ci: Remove the run_tests dependency on the run_cargodeny

* chore(stackable-versioned): Improve the formatting of the new entries in the changelog
  • Loading branch information
NickLarsenNZ authored Nov 29, 2024
1 parent 5dcb07b commit c5dc4f5
Show file tree
Hide file tree
Showing 15 changed files with 75 additions and 72 deletions.
1 change: 0 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ jobs:
run_tests:
name: Run Cargo Tests
needs:
- run_cargodeny
- run_clippy
- run_rustfmt
- run_rustdoc
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit c5dc4f5

Please sign in to comment.