feat: Add support for human-readable duration formats

[Techassi]

Fixes #649. This was discussed in an arch meeting roughly two weeks ago (when this PR was opened).

It is part of the effort to unify duration formats used in our CRDs. Operators would need to use the exported Duration type to support human-readable duration formats. This PR adds support for human-readable durations, like 2d2h20m42s or15d2m2s. The Duration type requirements are tracked in #649

These changes are breaking, because:

• in some cases the type changes from number to string
• in cases where string is already used, the parsing might be slightly different

Author

Preview Give feedback

1. Changes are OpenShift compatible
2. CRD changes approved

Reviewer

Preview Give feedback

1. Code contains useful comments
2. (Integration-)Test cases added
3. Documentation added or updated
4. Changelog updated
5. Cargo.toml only contains references to git tags (not specific commits or branches)

[Techassi]

In its current form, the Duration is not usable in const environments, thus we are unable to define constant values like here: https://github.com/stackabletech/trino-operator/blob/main/rust/crd/src/lib.rs#L124

There currently is an open issue upstream in humantime, but there seems little to no progress. We could, however, implement our own (simplified) parsing.

[Techassi]

Constant values are now possible:

use stackable_operator::duration::Duration;

const DEFAULT_TIMEOUT: Duration = Duration::from_secs(3600);

[Techassi]

Commit fe1911e breaks duration::test::parse_invalid::case_3. This change needs to be reverted.

[sbernauer]

Actual change LGTM, giving it a try with trino-op graceful shutdown

[sbernauer]

error[E0277]: cannot multiply `{integer}` by `stackable_operator::duration::Duration`
  --> rust/operator-binary/src/operations/graceful_shutdown.rs:46:13
   |
46 |         + 2 * GRACEFUL_SHUTDOWN_GRACE_PERIOD
   |             ^ no implementation for `{integer} * stackable_operator::duration::Duration`
   |
   = help: the trait `Mul<stackable_operator::duration::Duration>` is not implemented for `{integer}`

[sbernauer]

Looking at the generated deploy/helm/trino-operator/crds/crds.yaml, we have the following change I would have not expected.

                     gracefulShutdownTimeout:
                       default: 1h
                       description: Time period the trino workers have to gracefully shut down, e.g. `1h`, `30m` or `2d`. Consult the trino-operator documentation for details.
-                      type: string
+                      properties:
+                        nanos:
+                          format: uint32
+                          minimum: 0.0
+                          type: integer
+                        secs:
+                          format: uint64
+                          minimum: 0.0
+                          type: integer
+                      required:
+                        - nanos
+                        - secs
+                      type: object

[sbernauer]

@Techassi as discussed, pushed the fixes, please have a look

[sbernauer]

Tested and works fine for the trino graceful shutdown, awesome!
However, I would give @nightkr the chance to review the code again

[Techassi]

Yes, looks good! Waiting for final feedback from @nightkr

[nightkr]

Commit fe1911e breaks duration::test::parse_invalid::case_3. This change needs to be reverted.

Fair, I should have fixed those test cases.

[nightkr]

Commit fe1911e breaks duration::test::parse_invalid::case_3. This change needs to be reverted.

Fair, I should have fixed those test cases.

98149d7

[sbernauer]

Awesome, thanks for working on this!