Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Pdb struct and PdbBuilder #653

Merged
merged 25 commits into from
Sep 25, 2023
Merged

feat: Add Pdb struct and PdbBuilder #653

merged 25 commits into from
Sep 25, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 18, 2023 •
edited
Loading

Description

Part of stackabletech/issues#435

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

github-actions[bot]
github-actions bot reviewed Sep 18, 2023
View reviewed changes
src/role_utils.rs Outdated Show resolved Hide resolved
src/role_utils.rs Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Sep 19, 2023
View reviewed changes
src/builder/pdb.rs Outdated Show resolved Hide resolved
@sbernauer sbernauer mentioned this pull request Sep 19, 2023
Closed
@sbernauer sbernauer marked this pull request as ready for review September 19, 2023 13:46
@sbernauer sbernauer self-assigned this Sep 21, 2023
Techassi
Techassi requested changes Sep 22, 2023
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see some doc comments for the newly introduced Pdb and PdbBuilder structs, as well as all associated functions of the builder.

We can also think about renaming Pdb to PodDisruptionBudget and PdbBuilder to PodDisruptionBudgetBuilder. I think we currently do not abbreviate k8s terms in operator-rs.

src/builder/pdb.rs Outdated Show resolved Hide resolved
src/builder/pdb.rs Outdated Show resolved Hide resolved
src/builder/pdb.rs Outdated Show resolved Hide resolved
src/builder/pdb.rs Outdated Show resolved Hide resolved
src/builder/pdb.rs Outdated Show resolved Hide resolved
src/builder/pdb.rs Outdated Show resolved Hide resolved
src/builder/pdb.rs Show resolved Hide resolved
src/builder/pdb.rs Outdated Show resolved Hide resolved
src/builder/pdb.rs Outdated Show resolved Hide resolved
src/role_utils.rs Outdated Show resolved Hide resolved
@stackabletech stackabletech deleted a comment from Techassi Sep 22, 2023
@stackabletech stackabletech deleted a comment from Techassi Sep 22, 2023
@sbernauer
Copy link
Member Author

Fixed the abbreviation. Only thing missing are docs

@sbernauer sbernauer requested a review from Techassi September 25, 2023 08:46
Techassi
Techassi requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor nits, otherwise lgtm.

src/builder/pdb.rs Outdated Show resolved Hide resolved
src/builder/pdb.rs Outdated Show resolved Hide resolved
src/builder/pdb.rs Outdated Show resolved Hide resolved
src/builder/pdb.rs Show resolved Hide resolved
src/commons/pdb.rs Outdated Show resolved Hide resolved
src/commons/pdb.rs Show resolved Hide resolved
@sbernauer
Copy link
Member Author

@Techassi feedback addressed, please have another look

@sbernauer sbernauer requested a review from Techassi September 25, 2023 09:46
@sbernauer
Copy link
Member Author

Thanks a lot for the review!

@sbernauer sbernauer added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit 44f5201 Sep 25, 2023
16 checks passed
@sbernauer sbernauer deleted the feat/support-pdb branch September 25, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Techassi Techassi Techassi approved these changes

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @Techassi