Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make roleConfig customizable #661

Merged
merged 6 commits into from
Oct 5, 2023
Merged

feat: Make roleConfig customizable #661

merged 6 commits into from
Oct 5, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 4, 2023 •
edited by fhennig
Loading

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@sbernauer sbernauer self-assigned this Oct 5, 2023
@fhennig fhennig self-requested a review October 5, 2023 07:18
fhennig
fhennig suggested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry missing

src/product_config_utils.rs Show resolved Hide resolved
@sbernauer sbernauer requested a review from fhennig October 5, 2023 07:47
@sbernauer sbernauer enabled auto-merge October 5, 2023 08:26
@sbernauer sbernauer added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit 84e1c24 Oct 5, 2023
16 checks passed
@sbernauer sbernauer deleted the feat/customizable-role-config branch October 5, 2023 08:39
@sbernauer sbernauer mentioned this pull request Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhennig fhennig fhennig approved these changes

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @fhennig