Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add getting-started scripts PR template #408

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Jul 16, 2024

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just thinking I'm going to have to get used to using the PR templates, as currently I push the branch and click the link that Github sends back to create a PR with an empty template 🤔

@Techassi Techassi added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 54c449b Jul 16, 2024
17 checks passed
@Techassi Techassi deleted the chore/add-getting-started-scripts-template branch July 16, 2024 13:26
@Techassi
Copy link
Member Author

Personal reminder: This still needs to be rolled-out in downstream repos.

@@ -0,0 +1,34 @@
## Check and Update Getting Started Script
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the linter isn't running, as in the downstream repos it picks this up:

template/.github/PULL_REQUEST_TEMPLATE/pre-release-getting-started-script.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## Check and Update Getting St..."]

@@ -1,10 +1,15 @@
## Bump Rust Dependencies for Stackable Release XX.(X)X
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one:

template/.github/PULL_REQUEST_TEMPLATE/pre-release-rust-deps.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## Bump Rust Dependencies for ..."]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants