Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pass-through envOverrides #451

Merged
merged 13 commits into from
Aug 16, 2024
Merged

fix: Pass-through envOverrides #451

merged 13 commits into from
Aug 16, 2024

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Aug 14, 2024 •
edited
Loading

Description

fixed envOverrides and extended test. Fixes #362

OKD tests: 🟢

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@adwk67 adwk67 mentioned this pull request Aug 14, 2024
Closed
17 tasks
@adwk67 adwk67 marked this pull request as ready for review August 15, 2024 15:32
@adwk67 adwk67 self-assigned this Aug 15, 2024
@sbernauer sbernauer changed the title fix/pass-through envOverrides fix: Pass-through envOverrides Aug 16, 2024
@sbernauer sbernauer self-requested a review August 16, 2024 06:18
sbernauer
sbernauer requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments and one about the Rust test

CHANGELOG.md Outdated Show resolved Hide resolved
tests/templates/kuttl/overrides/11-assert.yaml Outdated Show resolved Hide resolved
rust/crd/src/history.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/history/history_controller.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/history/history_controller.rs Outdated Show resolved Hide resolved
adwk67 and others added 6 commits August 16, 2024 08:32
@adwk67 @sbernauer
Update CHANGELOG.md
944bf36 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@adwk67 @sbernauer
Update rust/crd/src/lib.rs
dc2f98f 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@adwk67 @sbernauer
Update rust/operator-binary/src/history/history_controller.rs
6f4b9da 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@adwk67
move merge-env logic to history.rs and improve unit test
248479d
@adwk67 @sbernauer
Update rust/crd/src/history.rs
890c675 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@adwk67
renamed test
53f7d59
@adwk67 adwk67 requested a review from sbernauer August 16, 2024 08:52
NickLarsenNZ
NickLarsenNZ previously approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some comments

rust/crd/src/constants.rs Show resolved Hide resolved
rust/crd/src/history.rs Show resolved Hide resolved
rust/crd/src/history.rs Outdated Show resolved Hide resolved
@adwk67 adwk67 requested a review from NickLarsenNZ August 16, 2024 09:25
@NickLarsenNZ NickLarsenNZ mentioned this pull request Aug 16, 2024
Open
sbernauer
sbernauer approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments have been addressed

@adwk67 adwk67 added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 696843a Aug 16, 2024
31 checks passed
@adwk67 adwk67 deleted the fix/consistent-overrides branch August 16, 2024 14:29
@razvan razvan mentioned this pull request Aug 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

@NickLarsenNZ NickLarsenNZ Awaiting requested review from NickLarsenNZ

Assignees

@adwk67 adwk67

Labels
release/2024-11 type/bug
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

envOverrides have no effect
4 participants
@adwk67 @NickLarsenNZ @sbernauer @maltesander