Skip to content

Commit

Permalink
cleaned up some comments, removed Tgz case
Browse files Browse the repository at this point in the history
  • Loading branch information
adwk67 committed Dec 19, 2024
1 parent b0fbdfc commit b9b6100
Show file tree
Hide file tree
Showing 11 changed files with 31 additions and 46 deletions.
18 changes: 6 additions & 12 deletions extra/completions/_stackablectl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions extra/completions/stackablectl.bash

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions extra/completions/stackablectl.fish

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions extra/completions/stackablectl.nu

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions rust/stackable-cockpit/src/platform/manifests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ pub enum Error {

pub trait InstallManifestsExt {
// TODO (Techassi): This step shouldn't care about templating the manifests nor fetching them from remote
// TODO aken: do we support helm charts from registries?
#[instrument(skip_all)]
#[allow(async_fn_in_trait)]
async fn install_manifests(
Expand Down Expand Up @@ -95,7 +94,7 @@ pub trait InstallManifestsExt {
helm_chart.name, helm_chart.version
);

// TODO aken: assuming all manifest helm charts refer to repos not registries
// Assumption: that all manifest helm charts refer to repos not registries
helm::add_repo(&helm_chart.repo.name, &helm_chart.repo.url).context(
AddHelmRepositorySnafu {
repo_name: helm_chart.repo.name.clone(),
Expand Down
4 changes: 0 additions & 4 deletions rust/stackable-cockpit/src/platform/operator/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ impl OperatorSpec {
let chart_source = match chart_source {
ChartSourceType::OCI => HELM_OCI_REGISTRY.to_string(),
ChartSourceType::Repo => self.helm_repo_name(),
ChartSourceType::Tgz => "TODO".to_string(),
};

// Install using Helm
Expand Down Expand Up @@ -237,9 +236,6 @@ pub enum ChartSourceType {

/// Nexus repositories: resolution (dev, test, stable) is based on the version and thus may be operator-specific
Repo,

/// Archive
Tgz,
}

#[cfg(test)]
Expand Down
Loading

0 comments on commit b9b6100

Please sign in to comment.