ci: Improve workflow files #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because workflow_run is weird and doesn't trigger on branches other than the default one like 'main' or 'master'. In conclusion: This trigger is weirdly designed and pretty much useless.
sbernauer
reviewed
Sep 28, 2023
No, but I can try it. |
nightkr
reviewed
Sep 28, 2023
| @@ -1,20 +1,16 @@ | |||
| # ============= | |||
There was a problem hiding this comment.
I assume the plan is to upstream this back into templating?
There was a problem hiding this comment.
Yes. This is the ultimate goal. Depends how much we can re-use in the operator repos tho.
| pull_request: | ||
| merge_group: |
There was a problem hiding this comment.
Definitely still want to run this for merge groups too?
There was a problem hiding this comment.
If we check on every PR, we should not need it when merging as the code is tested and built beforehand. This ensures we don't push broken code into main.
sbernauer
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by #98
This PR reworks and streamlines GitHub Action workflow files. It tries to reduce runs by selecting which workflows to run based on file paths. It also limits on which events these workflows get triggered.
We currently (and will never) allow direct pushes to
main. That's why it is sufficient to only run onpull_requestfor most of the workflows. Release workflows on the other hand get triggered by pushes (to main) with tags attached.EDIT: We might want to re-add the
merge_grouptrigger for workflow files which currently only usepull_request.actions-rs/clippy-checktogiraffate/clippy-actionStackable Build Pipelineinto new workflows