Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove colons from error messages #300

Merged
merged 3 commits into from
Jun 17, 2024
Merged

fix: Remove colons from error messages #300

merged 3 commits into from
Jun 17, 2024

Conversation

Techassi
Copy link
Member

The snafu report cleans up error messages by removing any content after a colon is encountered in the error message. This also messes up the output of structs when the Debug output is used. This was causing an issue when we failed to resolve a GVK.

The snafu report cleans up error messages by removing
any content after a colon is encoutered in the error
message. This also messes up the output of structs
when the Debug output is used. This was causing an
issue when we failed to resolve a GVK.
@Techassi Techassi self-assigned this Jun 17, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit debb9e8 Jun 17, 2024
34 checks passed
@Techassi Techassi deleted the fix/error-messages branch June 17, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants