Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sort operator versions by semver version #336

Merged
merged 13 commits into from
Nov 20, 2024
Merged

Conversation

sbernauer
Copy link
Member

Description

Before

stackablectl op desc airflow                          

 OPERATOR         airflow                                                                                                                           
 STABLE VERSIONS  0.1.0, 0.2.0, 0.3.0, 0.4.0, 0.5.0, 0.6.0, 23.1.0, 23.11.0, 23.4.0, 23.4.1, 23.7.0, 24.11.0, 24.3.0, 24.7.0                        
 TEST VERSIONS    0.0.0-pr517, 0.0.0-pr518, 0.0.0-pr519, 0.0.0-pr520, 0.0.0-pr521, 0.0.0-pr524, 0.0.0-pr525, 0.0.0-pr526, 0.0.0-pr527, 0.0.0-pr529, 
                  0.0.0-pr530, 0.0.0-pr531, 0.0.0-pr532, 0.0.0-pr533, 0.0.0-pr534, 0.0.0-pr537, 0.0.0-pr538, 0.0.0-pr539, 0.0.0-pr540               
 DEV VERSIONS     0.0.0-dev

After

cargo r -p stackablectl -- op desc airflow

 OPERATOR         airflow                                                                                                                           
 STABLE VERSIONS  0.1.0, 0.2.0, 0.3.0, 0.4.0, 0.5.0, 0.6.0, 23.1.0, 23.4.0, 23.4.1, 23.7.0, 23.11.0, 24.3.0, 24.7.0, 24.11.0                        
 TEST VERSIONS    0.0.0-pr517, 0.0.0-pr518, 0.0.0-pr519, 0.0.0-pr520, 0.0.0-pr521, 0.0.0-pr524, 0.0.0-pr525, 0.0.0-pr526, 0.0.0-pr527, 0.0.0-pr529, 
                  0.0.0-pr530, 0.0.0-pr531, 0.0.0-pr532, 0.0.0-pr533, 0.0.0-pr534, 0.0.0-pr537, 0.0.0-pr538, 0.0.0-pr539, 0.0.0-pr540               
 DEV VERSIONS     0.0.0-dev

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@sbernauer sbernauer changed the title fix: Sort operator versions by semver version instead of alphabetically fix: Sort operator versions by semver version Nov 18, 2024
Techassi
Techassi previously approved these changes Nov 18, 2024
@Techassi
Copy link
Member

The pre-commit error can be fixed by installing the Node dependencies. @NickLarsenNZ do we want to do this now, or force merge to get this fix into the 24.11.0 release of stackablectl?

@NickLarsenNZ
Copy link
Member

The pre-commit error can be fixed by installing the Node dependencies. @NickLarsenNZ do we want to do this now, or force merge to get this fix into the 24.11.0 release of stackablectl?

What are the tradeoffs of doing it now or leaving it until after the release?
(Sorry, brain is in a different place right now).

@Techassi
Copy link
Member

Techassi commented Nov 18, 2024

I see two options:

  • Don't merge this for the 24.11.0 release and instead merge it afterwards to create a 24.11.1 release
  • Merge it (and release it in 24.11.0) either by
    • ignoring the check and force-merging it. Fix the error afterwards in a separate PR.
    • fixing the issue in this PR.

@NickLarsenNZ
Copy link
Member

I see two options:

* Don't merge this for the 24.11.0 release and instead merge it afterwards to create a 24.11.1 release

* Merge it (and release it in 24.11.0) either by
  
  * ignoring the check and force-merging it. Fix the error afterwards in a separate PR.
  * fixing the issue in this PR

I would tend to go with leaving it out to save all the extra work, as I'm unsure how critical this is right now. Happy to let it go in if someone says they really want it in the release though.

@Techassi
Copy link
Member

Alright, then we leave it open for now and merge it for a 24.11.1 release of stackablectl.

@sbernauer sbernauer requested a review from Techassi November 19, 2024 07:40
@sbernauer
Copy link
Member Author

pre-commit action fixed and green ✔️

Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor comments.

rust/stackablectl/src/cmds/operator.rs Outdated Show resolved Hide resolved
rust/stackablectl/src/cmds/operator.rs Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
web/build.rs Outdated Show resolved Hide resolved
Co-authored-by: Techassi <git@techassi.dev>
@sbernauer sbernauer requested a review from Techassi November 20, 2024 12:14
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 0f62acd Nov 20, 2024
18 checks passed
@sbernauer sbernauer deleted the fix/version-sorting branch November 20, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants