-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added kleidukos/get-tested
action to generate CI matrix #64
#190
Conversation
536e64f
to
e7097bb
Compare
e7097bb
to
037e6f7
Compare
In addition to the GHC versions found in the That said, should consider if we want to add the |
Hi @DavidMazarro Thank you so much for working on this! We already have 5 ubuntu instances running. If we add macos to the matrix that will be 10. It seems a little bit too much. Let's look for an easy way to run macos for the last version of GHC. If we don't find one then we may want to keep the previous set up. |
From now on we will be officially supporting the latest minor versions of GHC 8.10, GHC 9.6 and GHC 9.8
2f03497
to
9a171df
Compare
9a171df
to
b2b0a1f
Compare
After discussing internally, we have decided that we will keep parity between Ubuntu and macOS runners, and we will be cutting the amount of GHC versions we test with. I updated the PR description with more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks to the get-tested action, we can automatically generate the matrix of GHC versions to run the CI on. This keeps the
tested-with
versions we set in Cabal files accurate to what is actually being tested in the CI.Since the action takes one Cabal file as reference, I pointed it to
rollbar-client.cabal
since that is the main library in this repository. In any case, us maintainers need to keep all of thetested-with
versions in sync across the four Haskell packages we offer in this repository.This PR also changes the
tested-with
versions of the Cabal in the project to the latest minor versions of GHC 8.10 (the latest GHC 8 version), GHC 9.6 and GHC 9.8 (the two most recent GHC 9 versions).Closes #189.