fix #522 #525
Closed
fix #522 #525
+150
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Thank you for digging into this @Byron. The changes here on the StGit end look pretty straightforward. I see that the accompanying changes on the gitoxide side of things are more extensive. Nice work! When the upstream changes land in a gitoxide release, I'll plan on incorporating these StGit changes. |
|
Thank you! And that's fantastic timing too as I happen to have a new release handy now. |
…-git#522) Previously assumptions were made about how shortened tracking branches would relate to remote names, and partial names would be set as `merge` field of local branch configuration. The latter could lead to Git being unable to perform certain operations. Now the correct full reference name is set.
|
Hi @Byron. I've reduced the whitespace changes to Cargo.toml in your first commit and then pushed those commits manually. Closing this PR accordingly. I also tried out these changes and they seem great. Thank you again for all the support you've given the Stacked Git project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #522.
Tasks
gixAPI to find the remote and upstream by reverse-refspec mappinggixto avoid Git dependency