Throw error if an expected release tag cannot be found, improve logs #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgellow
changed the title
| this.logger.warn( | ||
| `Expected ${expectedReleases} releases, only found ${releasesFound}` | ||
| ); | ||
| const errMessage = `Expected to find ${expectedReleases} releases, but ${ |
There was a problem hiding this comment.
I am still not sure about this. This will break customers and they most likely won't know what to do. Can we remedy it ourselves? If only one version is missing, we can maybe ignore it (and maybe generate a duplicate version)? Only when more than one is missing would we error out?
There was a problem hiding this comment.
Ok, let's keep this PR open for now, it's nothing urgent, we can change it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a version is mentioned in the manifest, but the release tag has been deleted manually, the current implementation reports the issue with warning logs at the beginning of the process.
In the case of Stainless, a missing release tag is likely to be due to a problem in the release process we would want to fix. So instead of a warning log this pull request throws an error with a meaningful error message.
I also cleaned up a bunch of logs that I found confusing and/or too noisy when I was debugging timeouts with sink-java-public (caused by deleted releases and tags).
See full context here and here.