Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Call() with symbols, not strings #1142

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

MichaelChirico
Copy link

@MichaelChirico MichaelChirico commented Oct 31, 2024

On my (rather baroque!) installation of R 4.4.1, loadNamespace("rstan") fails:

Error: package or namespace load failed for ‘rstan’:
 .onLoad failed in loadNamespace() for 'rstan', details:
  call: get_rng(0)
  error: DLL requires the use of native symbols
Error: loading failed

Per https://stackoverflow.com/q/76689311/3576984, there seems to be some (ongoing?) evolution on supplying routine names as strings, when they're registered and available as symbols.

Regardless of whether this is causing errors, I do think using the symbols when possible is preferable, hence filing this PR even though the issue I observe is not necessarily reproducible. c.f. lintr::routine_registration_linter().

@jgabry jgabry requested a review from bgoodri October 31, 2024 23:17
@jgabry
Copy link
Member

jgabry commented Oct 31, 2024

Thanks. @bgoodri can hopefully take a look, but seems fine to me to make this switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants