Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve y-006 and y-013 #659

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Conversation

vr8hub
Copy link
Contributor

@vr8hub vr8hub commented Mar 9, 2024

Per the discussion. I added an additional negative lookahead for the ellipsis, ran another test on the entire corpus, and the only differences were the ones with the ellipses. So, no false positives that I can see.

This will leave us with 86 works in the corpus that now have y-006 and/or y-013 errors (total of 98 errors). Do you want me to send a message to the editors to ask if they can help whittle it down? If so, and we find the text isn't a transcription error, would you consider fixing whatever is wrong Editorial? (It's going to be either adding a rsquo if the quote is valid, or reversing the rsquo if it's an elided word, or moving the comma/period inside the rsquo.)

@acabal acabal merged commit d07cad3 into standardebooks:master Mar 10, 2024
1 check passed
@acabal
Copy link
Member

acabal commented Mar 10, 2024

Great, thanks! If we're fixing a transcription error then it's not editorial, but if it's an obvious printer's typo then those are usually fixed in an editorial commit.

Are all of them absolutely errors of some kind?

@vr8hub
Copy link
Contributor Author

vr8hub commented Mar 10, 2024

I hesitate to say 100% because I haven't looked at all 100, but I've looked at most of them, and all the ones I've looked at are errors. Whether they're transcription or printer typos will have to be investigated by the person fixing them.

I'll send an email to the editors with a list of the works involved.

@acabal
Copy link
Member

acabal commented Mar 10, 2024

OK, sounds good. We can also probably just cut a release soon so they don't have to be on the dev install if they aren't yet.

@vr8hub
Copy link
Contributor Author

vr8hub commented Mar 10, 2024

Oh, right, yes, that would be good; that would also start catching more errors in any WIP.

@vr8hub vr8hub deleted the improve_y006_y013 branch March 10, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants