Fix broken overflow on wide unusual characters #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed that a 〃 DITTO MARK is apparently too wide for a single character, which means that the width=1 setup in rich.table converts it to an ellipsis in the Terminal. Which was confusing. Easy fix is just to remove the width constraint.
|
I must have put it in there for a reason, something must have come up during testing to compel me to set the width. I should have written a comment. Does the first column stretch wide if the terminal is wider than the table? |
|
Doesn’t seem to. 
|
|
OK! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that a 〃 DITTO MARK is apparently too wide for a single character, which means that the width=1 setup in rich.table converts it to an ellipsis in the Terminal. Which was confusing.
Easy fix is just to remove the width constraint.
This was added in 000d7c0, but doesn’t seem to be necessary for anything else I’m missing.