Remove y-023 from lint, add y-022 thru y-025 tests #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acabal
requested changes
May 22, 2024
se/se_epub_lint.py
Outdated
| @@ -474,7 +474,6 @@ | |||
| "y-019”, "Possible typo: [text]”[/] without opening [text]“[/]." | |||
| "y-020”, "Possible typo: consecutive comma-period ([text],.[/])." | |||
| "y-022”, "Possible typo: consecutive quotations without intervening text, e.g. [text]“…” “…”[/]." | |||
| "y-023”, "Possible typo: two opening quotation marks in a run. Hint: Nested quotes should switch between [text]“[/] and [text]‘[/]" | |||
| "y-024”, "Possible typo: dash before [text]the/there/is/and/they/when[/] probably should be em-dash." | |||
| "y-025”, "Possible typo: comma without space followed by quotation mark." | |||
There was a problem hiding this comment.
Can you also change the message in the comment?
|
Yep, sorry, I forgot about that, done. Per your other message, I already had a comment on here that rdquo was handled by y-012. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion, this removes y-023. (I've tried several ways and can't figure out the t-003 change, so I'll leave that with you; it works right now, it's just regex instead of xpath, so it's not pressing). Per another issue I opened a few minutes ago, the rdquo test in y-025 duplicates y-012 (but not vice-versa), so I removed it. I also clarified the message on y-025, because what was there did not align with what was actually being checked (I've been confused by that message on more than one occasion, and have had to look at the code each time).