Update mypy / pylint / pytest and make everything work on latest Pythons #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- a couple of branch removals - a couple of potentially unintialised variables
Neither of them affect the output any more.
We’re already exempting the from arg-type so let’s just add var-annotated and revisit another time.
These can be fixed in a separate chunk of work to remove importlib_resources.
|
Thanks! |
|
Scratch the followup PR for the time being: the suggested replacements for the deprecated methods all rely on Python 3.9+. We can do that later. |
|
Seeing as I was 80% of the way through the work anyway, I’ve completed it in the remove_importlib_resources branch. I’ll file an issue now pointing at the branch so that when we do baseline on 3.9+ we’ll be able to rebase and PR. |
|
OK, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current version, pylint on Python 3.12 throws a bunch of errors. Updating it to version 3+ fixes the majority of these issues. I’ve also fixed the other outstanding ones, removed a couple of now-empty ignores from pylintrc, and updated one ignore to work with the latest mypy.
I’ve added
deprecated-methodto pylintrc to silence issues with importlib_resources. As that module is no longer necessary now that the Python we require is >3.6 (see description at https://pypi.org/project/importlib-resources/1.0.2/) I’ll follow this PR up with a PR that updates the codebase to importlib.resources instead. We can removedeprecated-methodas part of that.