Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable colophon and imprint lints for white-label productions #717

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

apasel422
Copy link
Contributor

@apasel422 apasel422 commented Jun 21, 2024

Such productions may contain an imprint or colophon, but don't necessarily use the same format as Standard Ebooks.

@apasel422 apasel422 marked this pull request as ready for review June 21, 2024 21:00
@acabal
Copy link
Member

acabal commented Jun 22, 2024

I agree that we should disable lint checks for SE boilerplate files if they ebook is a white-label ebook. So you can modify this commit to skip the imprint and colophon checks if it's white label. However, some other special file checks, like endnotes and LoI, would still apply.

Such productions may contain an imprint or colophon, but don't
necessarily use the same format as Standard Ebooks.
@apasel422 apasel422 changed the title Disable M-035 for white-label productions Disable colophon and imprint lints for white-label productions Jun 22, 2024
@apasel422
Copy link
Contributor Author

So you can modify this commit to skip the imprint and colophon checks if it's white label.

Done!

@acabal acabal merged commit e4e305a into standardebooks:master Jun 22, 2024
1 check passed
@acabal
Copy link
Member

acabal commented Jun 22, 2024

Excellent, great work!

@apasel422 apasel422 deleted the m035 branch June 22, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants