Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broadcasted transaction #104

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: broadcasted transaction #104

wants to merge 2 commits into from

Conversation

jbcaron
Copy link
Collaborator

@jbcaron jbcaron commented Nov 22, 2024 •
edited
Loading

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Bugfix

What is the current behavior?

Resolves: #NA

What is the new behavior?

  • Added missing variant BroadcastedDeclareTxn::V3
  • Fixed query offset logic to align with specification requirements

Does this introduce a breaking change?

Other information

@jbcaron jbcaron self-assigned this Dec 2, 2024
@jbcaron jbcaron changed the title fix: add missing BroadcastedDeployAccountTxn::V3 variant fix: broadcasted transaction Dec 2, 2024
@jbcaron jbcaron requested a review from antiyro December 2, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdelabro tdelabro tdelabro approved these changes

@pefontana pefontana Awaiting requested review from pefontana pefontana is a code owner

@dan-starkware dan-starkware Awaiting requested review from dan-starkware dan-starkware is a code owner

@antiyro antiyro Awaiting requested review from antiyro

At least 2 approving reviews are required to merge this pull request.

Assignees

@jbcaron jbcaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbcaron @tdelabro