Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove option #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jbcaron
Copy link
Collaborator

@jbcaron jbcaron commented Dec 4, 2024

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Bugfix

What is the current behavior?

Resolves: #NA

What is the new behavior?

  • removal of Option<> for certain fields that the specifications do not explicitly define as required but should be

Does this introduce a breaking change?

Other information

@jbcaron jbcaron self-assigned this Dec 4, 2024
@jbcaron jbcaron requested review from antiyro and ArielElp December 4, 2024 14:46
Copy link
Collaborator

@tdelabro tdelabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you ask upstream to change the specs?
Otherwise, we will have to re-do this everytime we generate the code, won't we?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants