Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pedersen hash #12

Merged
merged 39 commits into from
Nov 7, 2023
Merged

Pedersen hash #12

merged 39 commits into from
Nov 7, 2023

Conversation

pefontana
Copy link
Collaborator

@pefontana pefontana commented Oct 27, 2023 •
edited
Loading

Pedersen hash

  • Create the StarkHash trait
  • Create the Pedersen struct that implements the StarkHash trait
  • Update README.md

Please add the labels corresponding to the type of changes your PR introduces:

  • Feature

Does this introduce a breaking change?

No

@pefontana
Create stark-cuve crate + naive implement ProjectivePoint
922eee7
@pefontana
Implement AffinePoint
5bff6a9
@pefontana
Add froms
05945f1
@pefontana
Implement ops::Add<&ProjectivePoint> for &ProjectivePoint
0a1bd07
@pefontana
remove starknet-types-core
b9ff318
@pefontana
Update .gitignore
79a7461
@pefontana
rename stark-felt -> starknet-types-core && Implement curve mod
c39043a
@pefontana
remove todo
f541949
@pefontana
Remove crates/stark-curve
6d92354
@pefontana
fix ensure_no_std
ffca830
@pefontana
Update commit
a7bf4eb
@pefontana
implement x(), y(), z() methods
c9a337b
@pefontana
little fix
fd14bf5
@pefontana
Divide the curve into two mods projective_point affine_point
ee74daa
@pefontana
minor fixes
0ddba75
@pefontana
Update Readme.md
eff975d
@pefontana
Fix to_affine method
abd9d51
@pefontana
Remove AffinePoint operations
6bafc48
@pefontana
Add tests
6862fd6
@pefontana
Add Error handle to to_affine method
b54dbdb
@pefontana
Add CurveError
3239971
@pefontana
docs
e5609a2
@pefontana
Update Cargo.toml
495c0da
@pefontana
docs
5d2a260
@pefontana
Restore .gitignore
b4da689
@pefontana
Docs
93d5f0a
@pefontana
Remove crates/.DS_Store
900cea3
@pefontana
Add curve feature
15bed72
@pefontana
Doc
971bef6
@pefontana
Add perdesen hash
07f9916
0xLucqs
0xLucqs reviewed Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@0xLucqs 0xLucqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have a hash trait so that we can swap between poseidon and pedersen easily in libs/projects

@pefontana pefontana marked this pull request as ready for review November 1, 2023 18:52
@pefontana
Copy link
Collaborator Author

I think we should have a hash trait so that we can swap between poseidon and pedersen easily in libs/projects

Sure @LucasLvy , sounds good
I created the StarkHash trait
https://github.com/starknet-io/types-rs/pull/12/files#diff-e595c2e9b33ab8cfece5d30cb912859fbf7aba4fbb84bb2895cbb168dc0b620e

@0xLucqs
Copy link
Collaborator

0xLucqs commented Nov 7, 2023

plz fix what @Oppen said so we can merge and get rolliiiiiiinnnnnn

@pefontana pefontana requested review from 0xLucqs and Oppen November 7, 2023 14:54
@0xLucqs 0xLucqs merged commit 8476f50 into starknet-io:main Nov 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanbono juanbono juanbono approved these changes

@Oppen Oppen Oppen approved these changes

@spapinistarkware spapinistarkware Awaiting requested review from spapinistarkware

@AbdelStark AbdelStark Awaiting requested review from AbdelStark

@dan-starkware dan-starkware Awaiting requested review from dan-starkware dan-starkware is a code owner

@xJonathanLEI xJonathanLEI Awaiting requested review from xJonathanLEI

@0xLucqs 0xLucqs Awaiting requested review from 0xLucqs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pefontana @0xLucqs @Oppen @juanbono