Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rpc): generate latest spec #60

Merged
merged 8 commits into from
Jul 23, 2024
Merged

chore(rpc): generate latest spec #60

merged 8 commits into from
Jul 23, 2024

Conversation

0xLucqs
Copy link
Collaborator

@0xLucqs 0xLucqs commented Apr 18, 2024

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Resolves: #NA

What is the new behavior?

Does this introduce a breaking change?

Other information

@0xLucqs 0xLucqs requested a review from pefontana as a code owner April 18, 2024 16:00
@0xLucqs 0xLucqs marked this pull request as draft April 18, 2024 16:13
0xLucqs
0xLucqs commented Jun 14, 2024
View reviewed changes
Copy link
Collaborator Author

@0xLucqs 0xLucqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should require the felt type to impl Debug, Display, Clone, Serialize, Deserialize

@maciejka maciejka marked this pull request as ready for review June 18, 2024 14:22
tdelabro
tdelabro requested changes Jun 27, 2024
View reviewed changes
crates/starknet-types-rpc/src/custom/query.rs Show resolved Hide resolved
crates/starknet-types-rpc/src/v0_7_1/starknet_api_openrpc.rs Outdated Show resolved Hide resolved
crates/starknet-types-rpc/src/v0_7_1/starknet_api_openrpc.rs Show resolved Hide resolved
crates/starknet-types-rpc/src/v0_7_1/starknet_api_openrpc.rs Show resolved Hide resolved
crates/starknet-types-rpc/src/v0_7_1/starknet_api_openrpc.rs Show resolved Hide resolved
crates/starknet-types-rpc/src/v0_7_1/starknet_api_openrpc.rs Show resolved Hide resolved
crates/starknet-types-rpc/src/v0_7_1/starknet_api_openrpc.rs Show resolved Hide resolved
crates/starknet-types-rpc/src/v0_7_1/starknet_api_openrpc.rs Show resolved Hide resolved
crates/starknet-types-rpc/src/v0_7_1/starknet_api_openrpc.rs Show resolved Hide resolved
crates/starknet-types-rpc/src/v0_7_1/starknet_write_api.rs Outdated Show resolved Hide resolved
@maciejka maciejka requested a review from tdelabro July 3, 2024 13:50
@maciejka maciejka force-pushed the lucas/update-rpc branch from c8ec431 to 01952db Compare July 3, 2024 13:51
@0xLucqs 0xLucqs merged commit f98f048 into main Jul 23, 2024
6 checks passed
@0xLucqs 0xLucqs deleted the lucas/update-rpc branch July 23, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdelabro tdelabro tdelabro approved these changes

@maciejka maciejka maciejka approved these changes

@pefontana pefontana Awaiting requested review from pefontana pefontana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xLucqs @maciejka @tdelabro