-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: impl TryInto<primitive> for Felt #74
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdelabro
force-pushed
the
try-primitive-from-felt
branch
4 times, most recently
from
June 19, 2024 17:58
b365bb8
to
cd1dee0
Compare
0xLucqs
requested changes
Jun 20, 2024
tdelabro
force-pushed
the
try-primitive-from-felt
branch
from
June 21, 2024 13:13
6342510
to
172feb9
Compare
0xLucqs
reviewed
Jun 24, 2024
tdelabro
force-pushed
the
try-primitive-from-felt
branch
from
June 26, 2024 15:29
769bab9
to
249e8c0
Compare
0xLucqs
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@pefontana or @juanbono we need a second reviewer |
10 tasks
@juanbono @pefontana @maciejka @Oppen we need a second reviewer! |
Oppen
approved these changes
Aug 19, 2024
pefontana
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.