Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl TryInto<primitive> for Felt #74

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

tdelabro
Copy link
Collaborator

No description provided.

@tdelabro tdelabro added the enhancement New feature or request label Jun 18, 2024
@tdelabro tdelabro requested a review from juanbono June 18, 2024 21:27
@tdelabro tdelabro force-pushed the try-primitive-from-felt branch 4 times, most recently from b365bb8 to cd1dee0 Compare June 19, 2024 17:58
@tdelabro tdelabro requested a review from 0xLucqs June 21, 2024 13:08
@tdelabro tdelabro force-pushed the try-primitive-from-felt branch from 6342510 to 172feb9 Compare June 21, 2024 13:13
@tdelabro tdelabro force-pushed the try-primitive-from-felt branch from 769bab9 to 249e8c0 Compare June 26, 2024 15:29
@tdelabro tdelabro requested a review from 0xLucqs June 26, 2024 15:38
Copy link
Collaborator

@0xLucqs 0xLucqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tdelabro
Copy link
Collaborator Author

@pefontana or @juanbono we need a second reviewer

@tdelabro
Copy link
Collaborator Author

tdelabro commented Aug 1, 2024

@juanbono @pefontana @maciejka @Oppen we need a second reviewer!

@tdelabro
Copy link
Collaborator Author

@0xLucqs @maciejka, it looks like oppen review doesn't qualify for merging. Can you give me another that does?

@pefontana pefontana merged commit 0de404d into starknet-io:main Sep 16, 2024
4 checks passed
@tdelabro tdelabro deleted the try-primitive-from-felt branch September 16, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants