fix: ftm::Debug impl fails to compile
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ftm::Debug` impl fails to compile unless the `alloc` feature is on. The underlying math lib allows `alloc`-free hex output, except it's not fixed-width like the current impl does. This technically changes the debug output format, but it should be worth it for getting to avoid requiring `alloc` for just debug printing. Also adds a GitHub Actions workflow to check that all feature combinations would compile correctly so that this doesn't happen again.
xJonathanLEI
force-pushed
the
fix/debug_alloc
branch
from
a055280 to
c8c6a69
Compare
0xLucqs
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ftm::Debugimpl fails to compile unless theallocfeature is on. The underlying math lib allowsalloc-free hex output, except it's not fixed-width like the current impl does.This technically changes the debug output format, but it should be worth it for getting to avoid requiring
allocfor just debug printing.Also adds a GitHub Actions workflow to check that all feature combinations would compile correctly so that this doesn't happen again.