Skip to content

Commit

Permalink
fix(tests-integration): remove deploy from e2e (#1050)
Browse files Browse the repository at this point in the history
Not supported yet, we need to be able to execute in batcher and close
blocks before we can do anything interesting here.

Specifically, invokes won't pass the GW until an account is deployed, so
until we can expicitely close blocks we can't use deploys and invokes
inside the same test.

Co-Authored-By: Gilad Chase <gilad@starkware.com>
  • Loading branch information
giladchase and Gilad Chase authored Sep 26, 2024
1 parent 2fb9f32 commit 1128cce
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions crates/tests-integration/tests/end_to_end_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,12 @@ async fn test_end_to_end() {
];
let (mock_running_system, mut tx_generator) = setup_with_tx_generation(&accounts).await;

let account0_deploy_nonce0 = &tx_generator.account_with_id(0).generate_default_deploy_account();
let account0_invoke_nonce1 = tx_generator.account_with_id(0).generate_default_invoke();
let account1_invoke_nonce0 = tx_generator.account_with_id(1).generate_default_invoke();
let account0_invoke_nonce2 = tx_generator.account_with_id(0).generate_default_invoke();

// Test.

let account0_deploy_nonce0_tx_hash =
mock_running_system.assert_add_tx_success(account0_deploy_nonce0).await;

mock_running_system.assert_add_tx_success(&account0_invoke_nonce1).await;

// FIXME: invoke with nonce0 shouldn't be possible, fix it, make this FAIL.
Expand All @@ -38,8 +34,7 @@ async fn test_end_to_end() {

// Only the transactions with nonce 0 should be returned from the mempool,
// because we haven't merged queue-replenishment yet.
let expected_tx_hashes_from_get_txs =
[account1_invoke_nonce0_tx_hash, account0_deploy_nonce0_tx_hash];
let expected_tx_hashes_from_get_txs = [account1_invoke_nonce0_tx_hash];

// This assert should be replaced with 4 once queue-replenishment is merged, also add a tx hole
// at that point, and ensure the assert doesn't change due to that.
Expand Down

0 comments on commit 1128cce

Please sign in to comment.